spl: Add a define for SPL_TPL_PROMPT

We should use a macro rather than hard-coding the SPL prompt to 'spl'
since the code can be used by TPL too. Add a macro that works for both
and use it in various places.

This allows TPL to use the same code without printing confusing messages.

Note that the string is lower case ('spl', 'tpl') which is a change from
previously.

Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/common/spl/spl.c b/common/spl/spl.c
index eea92ec1f8ca898484dad1385a162736eb3aa455..23be33c5c109358607fe33f4792a7dfde14c9aed 100644 (file)
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -58,8 +58,9 @@ __weak void show_boot_progress(int val) {}
 #ifdef CONFIG_SPL_OS_BOOT
 __weak int spl_start_uboot(void)
 {
-       puts("SPL: Please implement spl_start_uboot() for your board\n");
-       puts("SPL: Direct Linux boot not active!\n");
+       puts(SPL_TPL_PROMPT
+            "Please implement spl_start_uboot() for your board\n");
+       puts(SPL_TPL_PROMPT "Direct Linux boot not active!\n");
        return 1;
 }
 
@@ -101,13 +102,13 @@ void spl_fixup_fdt(void)
        /* fixup the memory dt node */
        err = fdt_shrink_to_minimum(fdt_blob, 0);
        if (err == 0) {
-               printf("spl: fdt_shrink_to_minimum err - %d\n", err);
+               printf(SPL_TPL_PROMPT "fdt_shrink_to_minimum err - %d\n", err);
                return;
        }
 
        err = arch_fixup_fdt(fdt_blob);
        if (err) {
-               printf("spl: arch_fixup_fdt err - %d\n", err);
+               printf(SPL_TPL_PROMPT "arch_fixup_fdt err - %d\n", err);
                return;
        }
 #endif
@@ -186,7 +187,7 @@ static int spl_load_fit_image(struct spl_image_info *spl_image,
        spl_image->os = IH_OS_U_BOOT;
        spl_image->name = "U-Boot";
 
-       debug("spl: payload image: %32s load addr: 0x%lx size: %d\n",
+       debug(SPL_TPL_PROMPT "payload image: %32s load addr: 0x%lx size: %d\n",
              spl_image->name, spl_image->load_addr, spl_image->size);
 
 #ifdef CONFIG_SPL_FIT_SIGNATURE
@@ -256,7 +257,8 @@ int spl_parse_image_header(struct spl_image_info *spl_image,
                }
                spl_image->os = image_get_os(header);
                spl_image->name = image_get_name(header);
-               debug("spl: payload image: %32s load addr: 0x%lx size: %d\n",
+               debug(SPL_TPL_PROMPT
+                     "payload image: %32s load addr: 0x%lx size: %d\n",
                      spl_image->name, spl_image->load_addr, spl_image->size);
 #else
                /* LEGACY image not supported */
@@ -285,7 +287,8 @@ int spl_parse_image_header(struct spl_image_info *spl_image,
                        spl_image->load_addr = CONFIG_SYS_LOAD_ADDR;
                        spl_image->entry_point = CONFIG_SYS_LOAD_ADDR;
                        spl_image->size = end - start;
-                       debug("spl: payload zImage, load addr: 0x%lx size: %d\n",
+                       debug(SPL_TPL_PROMPT
+                             "payload zImage, load addr: 0x%lx size: %d\n",
                              spl_image->load_addr, spl_image->size);
                        return 0;
                }
@@ -469,7 +472,7 @@ static int boot_from_devices(struct spl_image_info *spl_image,
                if (loader)
                        printf("Trying to boot from %s\n", loader->name);
                else
-                       puts("SPL: Unsupported Boot Device!\n");
+                       puts(SPL_TPL_PROMPT "Unsupported Boot Device!\n");
 #endif
                if (loader && !spl_load_image(spl_image, loader)) {
                        spl_image->boot_device = spl_boot_list[i];
@@ -492,7 +495,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
        struct spl_image_info spl_image;
        int ret;
 
-       debug(">>spl:board_init_r()\n");
+       debug(">>" SPL_TPL_PROMPT "board_init_r()\n");
 
        spl_set_bd();
 
@@ -532,7 +535,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 
        if (boot_from_devices(&spl_image, spl_boot_list,
                              ARRAY_SIZE(spl_boot_list))) {
-               puts("SPL: failed to boot from all boot devices\n");
+               puts(SPL_TPL_PROMPT "failed to boot from all boot devices\n");
                hang();
        }
 
@@ -605,8 +608,8 @@ void preloader_console_init(void)
        gd->have_console = 1;
 
 #ifndef CONFIG_SPL_DISABLE_BANNER_PRINT
-       puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
-                       U_BOOT_TIME " " U_BOOT_TZ ")\n");
+       puts("\nU-Boot " SPL_TPL_NAME " " PLAIN_VERSION " (" U_BOOT_DATE " - "
+            U_BOOT_TIME " " U_BOOT_TZ ")\n");
 #endif
 #ifdef CONFIG_SPL_DISPLAY_PRINT
        spl_display_print();

diff --git a/include/spl.h b/include/spl.h
index a56032ae3ebd2bef749f49349482e6c4c761afe5..205aaff4b9df9f04afdc8695c9c42b7d44f1d719 100644 (file)
--- a/include/spl.h
+++ b/include/spl.h
@@ -48,6 +48,19 @@ static inline bool u_boot_first_phase(void)
        return false;
 }
 
+/* A string name for SPL or TPL */
+#ifdef CONFIG_SPL_BUILD
+# ifdef CONFIG_TPL_BUILD
+#  define SPL_TPL_NAME "tpl"
+# else
+#  define SPL_TPL_NAME "spl"
+# endif
+# define SPL_TPL_PROMPT        SPL_TPL_NAME ": "
+#else
+# define SPL_TPL_NAME  ""
+# define SPL_TPL_PROMPT        ""
+#endif
+
 struct spl_image_info {
        const char *name;
        u8 os;

diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index 326b2ac51fbf07daa2e2af0385e9358d8cf9398f..e044eb3ea1d1b1eaeb3023fe673b9d8ae1b225c9 100644 (file)
--- a/test/py/u_boot_console_base.py
+++ b/test/py/u_boot_console_base.py
@@ -16,7 +16,7 @@ import sys
 import u_boot_spawn
 
 # Regexes for text we expect U-Boot to send to the console.
-pattern_u_boot_spl_signon = re.compile('(U-Boot SPL \\d{4}\\.\\d{2}[^\r\n]*\\))')
+pattern_u_boot_spl_signon = re.compile('(U-Boot spl \\d{4}\\.\\d{2}[^\r\n]*\\))')
 pattern_u_boot_main_signon = re.compile('(U-Boot \\d{4}\\.\\d{2}[^\r\n]*\\))')
 pattern_stop_autoboot_prompt = re.compile('Hit any key to stop autoboot: ')
 pattern_unknown_command = re.compile('Unknown command \'.*\' - try \'help\'')