]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mmc: sdhci: Correct ADMA_DESC_LEN to 12
authorAlexander Sverdlin <alexander.sverdlin@siemens.com>
Wed, 1 May 2024 18:53:04 +0000 (20:53 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 2 May 2024 16:34:34 +0000 (10:34 -0600)
Commit 37cb626da25d0d ("mmc: sdhci: Add Support for ADMA2") introduced
ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit
74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops").

"sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead.

Confusion probably originates from Linux commit 685e444bbaa0
("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but
the latter "V4 mode" was never ported to U-Boot.

Fixes: 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Tested-by: Jonathan Humphreys <j-humphreys@ti.com>
Tested-by: Judith Mendez <jm@ti.com>
include/sdhci.h

index 78ef0d1c088db5739c4ab9000e214415964cfcda..31a49ca6a2f8b7efdb67a77ae8f147167998e49d 100644 (file)
@@ -301,7 +301,7 @@ struct sdhci_ops {
 
 #define ADMA_MAX_LEN   65532
 #ifdef CONFIG_MMC_SDHCI_ADMA_64BIT
-#define ADMA_DESC_LEN  16
+#define ADMA_DESC_LEN  12
 #else
 #define ADMA_DESC_LEN  8
 #endif