buildman: Use spaces in the board list

At present the board names shown with -l are separated by commas. This
makes it hard to double-click to select a particular board. Also it is not
possible to select all boards and paste them as arguments to a subsequent
buildman run, since buildman requires spaces to separate the list on the
command line, not commas.

Change the output format to use spaces instead of commas.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index 7cbb1a6f628c87fcc95f830480e60953e350f2a9..e895ab73d8d9ef367a371db40cc9a031e0af3f23 100644 (file)
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -1253,7 +1253,7 @@ class Builder:
                 for line in err_lines:
                     boards = ''
                     names = [board.target for board in line.boards]
-                    board_str = ','.join(names) if names else ''
+                    board_str = ' '.join(names) if names else ''
                     if board_str:
                         out = self.col.Color(colour, line.char + '(')
                         out += self.col.Color(self.col.MAGENTA, board_str,

diff --git a/tools/buildman/test.py b/tools/buildman/test.py
index a64372dee369ab906d1b8bc07d1ce855f615e929..a495df030365c385e709008a42ee31f68db475af 100644 (file)
--- a/tools/buildman/test.py
+++ b/tools/buildman/test.py
@@ -249,9 +249,9 @@ class TestBuild(unittest.TestCase):
                 new_lines.append(expect)
             return '\n'.join(new_lines)
 
-        boards1234 = 'board1,board2,board3,board4' if list_error_boards else ''
-        boards234 = 'board2,board3,board4' if list_error_boards else ''
-        boards34 = 'board3,board4' if list_error_boards else ''
+        boards1234 = 'board1 board2 board3 board4' if list_error_boards else ''
+        boards234 = 'board2 board3 board4' if list_error_boards else ''
+        boards34 = 'board3 board4' if list_error_boards else ''
         boards4 = 'board4' if list_error_boards else ''
 
         # Upstream commit: no errors