pci: Fix device_find_first_child() return value handling

This function only ever returns 0, but may not assign the second
parameter. Same thing for device_find_next_child(). Do not assign
ret to stop proliferation of this misuse.

Reported-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 7f3d6ddf91c91247e3dda9c59261e1f8a82c12c8..0adcdceb1d34fc21cf4aeebe4bcbfdf1d3307bee 100644 (file)
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -541,14 +541,13 @@ int pci_auto_config_devices(struct udevice *bus)
        struct pci_child_plat *pplat;
        unsigned int sub_bus;
        struct udevice *dev;
-       int ret;
 
        sub_bus = dev_seq(bus);
        debug("%s: start\n", __func__);
        pciauto_config_init(hose);
-       for (ret = device_find_first_child(bus, &dev);
-            !ret && dev;
-            ret = device_find_next_child(&dev)) {
+       for (device_find_first_child(bus, &dev);
+            dev;
+            device_find_next_child(&dev)) {
                unsigned int max_bus;
                int ret;