]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
arm64: Use level-2 for largest block mappings when FEAT_HAFDBS is present
authorMarc Zyngier <maz@kernel.org>
Fri, 17 Mar 2023 16:22:52 +0000 (00:22 +0800)
committerTom Rini <trini@konsulko.com>
Tue, 25 Apr 2023 19:31:27 +0000 (15:31 -0400)
In order to make invalidation by VA more efficient, set the largest
block mapping to 2MB, mapping it onto level-2. This has no material
impact on u-boot's runtime performance, and allows a huge speedup
when cleaning the cache.

Signed-off-by: Marc Zyngier <maz@kernel.org>
[ Paul: pick from the Android tree. Rebase to the upstream ]
Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
Cc: Tom Rini <trini@konsulko.com>
Link: https://android.googlesource.com/platform/external/u-boot/+/417a73581a72ff6d6ee4b0938117b8a23e32f7e8
arch/arm/cpu/armv8/cache_v8.c
arch/arm/include/asm/global_data.h

index 4760064ee18f9427e28bca9e0f61e5c23815b101..4c6a1b1d6c5ee74f03fc39da7ca2f8dd53617cd0 100644 (file)
@@ -314,7 +314,7 @@ static void map_range(u64 virt, u64 phys, u64 size, int level,
        for (i = idx; size; i++) {
                u64 next_size, *next_table;
 
-               if (level >= 1 &&
+               if (level >= gd->arch.first_block_level &&
                    size >= map_size && !(virt & (map_size - 1))) {
                        if (level == 3)
                                table[i] = phys | attrs | PTE_TYPE_PAGE;
@@ -353,6 +353,9 @@ static void add_map(struct mm_region *map)
        if (va_bits < 39)
                level = 1;
 
+       if (!gd->arch.first_block_level)
+               gd->arch.first_block_level = 1;
+
        if (gd->arch.has_hafdbs)
                attrs |= PTE_DBM | PTE_RDONLY;
 
@@ -369,7 +372,7 @@ static void count_range(u64 virt, u64 size, int level, int *cntp)
        for (i = idx; size; i++) {
                u64 next_size;
 
-               if (level >= 1 &&
+               if (level >= gd->arch.first_block_level &&
                    size >= map_size && !(virt & (map_size - 1))) {
                        virt += map_size;
                        size -= map_size;
@@ -410,10 +413,13 @@ __weak u64 get_page_table_size(void)
        u64 size, mmfr1;
 
        asm volatile("mrs %0, id_aa64mmfr1_el1" : "=r" (mmfr1));
-       if ((mmfr1 & 0xf) == 2)
+       if ((mmfr1 & 0xf) == 2) {
                gd->arch.has_hafdbs = true;
-       else
+               gd->arch.first_block_level = 2;
+       } else {
                gd->arch.has_hafdbs = false;
+               gd->arch.first_block_level = 1;
+       }
 
        /* Account for all page tables we would need to cover our memory map */
        size = one_pt * count_ranges();
index 6956182accbad4c68d69f864c12216cf9ac15b43..0c130757110a51e4ea33cd86bbf276f8c0a42134 100644 (file)
@@ -52,6 +52,7 @@ struct arch_global_data {
 #if defined(CONFIG_ARM64)
        unsigned long tlb_fillptr;
        unsigned long tlb_emerg;
+       unsigned int first_block_level;
        bool has_hafdbs;
 #endif
 #endif