]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_loader: fix efi_load_image_from_path()
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Wed, 20 Jan 2021 21:57:46 +0000 (22:57 +0100)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Sat, 23 Jan 2021 06:56:53 +0000 (07:56 +0100)
Use the correct GUID when closing the file load protocol.
Remove an unnecessary check (Coverity CID 316363).

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_boottime.c

index b2cb0160c08f47444f64a071200f084db2ed4b35..18ca96791c08f102b08f5a161f2b1f870520a8de 100644 (file)
@@ -1990,10 +1990,7 @@ efi_status_t efi_load_image_from_path(bool boot_policy,
        if (ret != EFI_SUCCESS)
                efi_free_pages(addr, pages);
 out:
-       if (load_file_protocol)
-               EFI_CALL(efi_close_protocol(device,
-                                           &efi_guid_load_file2_protocol,
-                                           efi_root, NULL));
+       EFI_CALL(efi_close_protocol(device, guid, efi_root, NULL));
        if (ret == EFI_SUCCESS) {
                *buffer = (void *)(uintptr_t)addr;
                *size = buffer_size;