]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: xhci: Add missing cache flush in the scratchpad array initialization
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Mon, 25 May 2020 11:39:51 +0000 (13:39 +0200)
committerMatthias Brugger <mbrugger@suse.com>
Thu, 9 Jul 2020 13:46:12 +0000 (15:46 +0200)
In current code there is no cache flush after initializing the scratchpad
buffer array with the scratchpad buffer pointers. This leads to a failure
of the "slot enable" command on the rpi4 board (Broadcom STB PCIe
controller + VL805 USB hub) - the very first TRB transfer on the command
ring fails and there is a timeout while waiting for the command completion
event. After adding the missing cache flush everything seems to be working
as expected.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
drivers/usb/host/xhci-mem.c

index 2d968aafb03eddb1948ec3308d87df146a98fdf7..f4465205284584bb0c175dbdf172245a7ec3ebfb 100644 (file)
@@ -395,6 +395,9 @@ static int xhci_scratchpad_alloc(struct xhci_ctrl *ctrl)
                scratchpad->sp_array[i] = cpu_to_le64(ptr);
        }
 
+       xhci_flush_cache((uintptr_t)scratchpad->sp_array,
+                        sizeof(u64) * num_sp);
+
        return 0;
 
 fail_sp3: