efi_loader: correct check in efi_load_option_dp_join()

After assigning to *dp we must check this value and not dp.

Addresses-Coverity-ID: 501792 Control flow issues (DEADCODE)
Fixes: 58bef195f94e ("cmd: eficonfig: add support for setting fdt")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/lib/efi_loader/efi_helper.c b/lib/efi_loader/efi_helper.c
index 348612c3dad1b7ab3e5a89d8d7eaf884eea627ec..65d2116381aee8fbf19a3a9a6169c56c5d524493 100644 (file)
--- a/lib/efi_loader/efi_helper.c
+++ b/lib/efi_loader/efi_helper.c
@@ -133,7 +133,7 @@ efi_status_t efi_load_option_dp_join(struct efi_device_path **dp,
 
                *dp = efi_dp_concat(tmp_dp, fdt_dp, *dp_size);
                efi_free_pool(tmp_dp);
-               if (!dp)
+               if (!*dp)
                        return EFI_OUT_OF_RESOURCES;
                *dp_size += efi_dp_size(fdt_dp) + sizeof(END);
        }