]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
sandbox: cros_ec: fix uninitialized use of len
authorDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
Fri, 6 Nov 2015 13:15:37 +0000 (14:15 +0100)
committerSimon Glass <sjg@chromium.org>
Fri, 20 Nov 2015 03:13:42 +0000 (20:13 -0700)
Building with gcc-5.2 raises this warning:

drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet:
drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (len < 0)
     ^

If the function process_cmd() is called with
req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be
returned uninitialized.

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
drivers/misc/cros_ec_sandbox.c

index 7509612fb8370d62482636deb86e82b22eb47e56..98f19a68bf6fb4b0650e69dcf06bcfebc2c349e8 100644 (file)
@@ -460,6 +460,7 @@ static int process_cmd(struct ec_state *ec,
                len = cros_ec_keyscan(ec, resp_data);
                break;
        case EC_CMD_ENTERING_MODE:
+               len = 0;
                break;
        default:
                printf("   ** Unknown EC command %#02x\n", req_hdr->command);