smbios: Require the caller to align the SMBIOS table

All callers handle this alignment, so drop the unnecessary code. This
simplifies things a little.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/include/smbios.h b/include/smbios.h
index 77be58887a2b775b9a174ef5fdc030fc40092a09..49de32fec2deb7edf1cfe4d98971a83e71cc8a1d 100644 (file)
--- a/include/smbios.h
+++ b/include/smbios.h
@@ -258,12 +258,13 @@ static inline void fill_smbios_header(void *table, int type,
  *
  * This writes SMBIOS table at a given address.
  *
- * @addr:      start address to write SMBIOS table. If this is not
- *             16-byte-aligned then it will be aligned before the table is
- *             written.
+ * @addr:      start address to write SMBIOS table, 16-byte-alignment
+ * recommended. Note that while the SMBIOS tables themself have no alignment
+ * requirement, some systems may requires alignment. For example x86 systems
+ * which put tables at f0000 require 16-byte alignment
+ *
  * Return:     end address of SMBIOS table (and start address for next entry)
  *             or NULL in case of an error
- *
  */
 ulong write_smbios_table(ulong addr);
 

diff --git a/lib/smbios.c b/lib/smbios.c
index 7f79d969c9221b4571cf8cf503a41d3646baf6a2..cfd451e4088a4e61c82b6190775a4569efead832 100644 (file)
--- a/lib/smbios.c
+++ b/lib/smbios.c
@@ -563,8 +563,6 @@ ulong write_smbios_table(ulong addr)
                ctx.dev = NULL;
        }
 
-       /* 16 byte align the table address */
-       addr = ALIGN(addr, 16);
        start_addr = addr;
 
        /*