]> git.dujemihanovic.xyz Git - u-boot.git/commit
mmc: sdhci: Correct ADMA_DESC_LEN to 12
authorAlexander Sverdlin <alexander.sverdlin@siemens.com>
Wed, 1 May 2024 18:53:04 +0000 (20:53 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 2 May 2024 16:34:34 +0000 (10:34 -0600)
commitc92d48f8b2909d08584f17612a23d959467f14b8
treedca3f592b65ad01702e808e3a8a85a19103ed2a5
parent62825d48c4151dadb59c106f9a1fb1a5ccb241a0
mmc: sdhci: Correct ADMA_DESC_LEN to 12

Commit 37cb626da25d0d ("mmc: sdhci: Add Support for ADMA2") introduced
ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit
74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops").

"sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead.

Confusion probably originates from Linux commit 685e444bbaa0
("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but
the latter "V4 mode" was never ported to U-Boot.

Fixes: 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Tested-by: Jonathan Humphreys <j-humphreys@ti.com>
Tested-by: Judith Mendez <jm@ti.com>
include/sdhci.h