]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: gadget: Add full ep_matches() check past .match_ep() callback
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sun, 9 Jun 2024 21:32:18 +0000 (23:32 +0200)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Fri, 5 Jul 2024 12:01:19 +0000 (14:01 +0200)
commitbd7ec7b04f877b8b4a88d4367f100dc3f0af27a3
tree137703d8472a2e2a3aa03c53d28328917e819424
parentdb62b6a0a016b69cf0e26eea4004c3edbebd4394
usb: gadget: Add full ep_matches() check past .match_ep() callback

If .match_ep() callback returns non-NULL endpoint, immediately check
its usability and if the returned endpoint is usable, stop search and
return the endpoint. Otherwise, continue with best effort search for
usable endpoint.

Currently the code would attempt the best effort search in any case,
which may find another unexpected endpoint. It is likely that the
intention of the original code was to stop the search early.

Fixes: 77dcbdf3c1ce ("usb: gadget: Add match_ep() op to usb_gadget_ops")
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on vim3
Link: https://lore.kernel.org/r/20240609213449.194762-5-marek.vasut+renesas@mailbox.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
drivers/usb/gadget/epautoconf.c