From: Jim Liu Date: Mon, 8 Apr 2024 08:49:02 +0000 (+0800) Subject: net: designware: Invalidate RX buffer cache before freeing the DMA descriptor X-Git-Url: http://git.dujemihanovic.xyz/img/static/%7B%7B%20%24image.RelPermalink%20%7D%7D?a=commitdiff_plain;h=3d98b8c504e158d708ca806b4aac9d40757e8c01;p=u-boot.git net: designware: Invalidate RX buffer cache before freeing the DMA descriptor In IPv6 context, the ICMP and UDP checksum byte in the RX packet is initially set to 0, recaclculated, and then re-inserted. This process can result in a dirty cache line. To prevent issues, it is essential to invalidate cache for the RX buffer before freeing the descriptor for next DMA transfer. This ensure that the dirty cache line doesn't inadvertently written back due to cache eviction, there by corrupting the RX buffer Signed-off-by: Parvathi Bhogaraju Signed-off-by: Jim Liu --- diff --git a/drivers/net/designware.c b/drivers/net/designware.c index c222197b11..03b531c667 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -554,6 +554,11 @@ static int _dw_free_pkt(struct dw_eth_dev *priv) ulong desc_start = (ulong)desc_p; ulong desc_end = desc_start + roundup(sizeof(*desc_p), ARCH_DMA_MINALIGN); + ulong data_start = desc_p->dmamac_addr; + ulong data_end = data_start + roundup(CFG_ETH_BUFSIZE, ARCH_DMA_MINALIGN); + + /* Invalidate the descriptor buffer data */ + invalidate_dcache_range(data_start, data_end); /* * Make the current descriptor valid again and go to