From f5e921e948149bdf7c5bb6b97647bc4712d5993a Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 30 Sep 2023 14:01:43 +0200 Subject: [PATCH] freescale: fix long help handling in mac command CONFIG_SYS_LONGHELP=n we want to reduce the size of the U-Boot binary. The long text should be reduced to and empty string in this case. There is not need to call cmd_usage() directly. It is sufficient to return CMD_RET_USAGE. Signed-off-by: Heinrich Schuchardt --- board/freescale/common/sys_eeprom.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/board/freescale/common/sys_eeprom.c b/board/freescale/common/sys_eeprom.c index d4a00fe920..9363251dc2 100644 --- a/board/freescale/common/sys_eeprom.c +++ b/board/freescale/common/sys_eeprom.c @@ -424,7 +424,7 @@ int do_mac(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) prog_eeprom(); break; default: - return cmd_usage(cmdtp); + return CMD_RET_USAGE; } return 0; @@ -624,9 +624,8 @@ unsigned int get_cpu_board_revision(void) } #endif -U_BOOT_CMD( - mac, 3, 1, do_mac, - "display and program the system ID and MAC addresses in EEPROM", +#ifdef CONFIG_SYS_LONGHELP +static char booti_help_text[] = "[read|save|id|num|errata|date|ports|port_number]\n" "mac read\n" " - read EEPROM content into memory data structure\n" @@ -643,5 +642,12 @@ U_BOOT_CMD( "mac ports N\n" " - program the number of network ports to integer N\n" "mac X string\n" - " - program MAC addr for port X [X=0,1..] to colon separated string" -); + " - program MAC addr for port X [X=0,1..] to colon separated string"; +#else + ""; +#endif + +U_BOOT_CMD( + mac, 3, 1, do_mac, + "display and program the system ID and MAC addresses in EEPROM", + booti_help_text); -- 2.39.5