From 9ed6f929a34b87c4bf06f01d84d8c58b0586b53a Mon Sep 17 00:00:00 2001 From: Patrick Delaunay Date: Thu, 15 Oct 2020 15:01:13 +0200 Subject: [PATCH] remoteproc: stm32: update error management in stm32_copro_start The coprocessor is running as soon as the hold boot is de-asserted. So indicate this running state and save the resource table even if the protective assert, to avoid autonomous reboot, is failed. This error case should never occurs. Cc: Fabien DESSENNE Cc: Arnaud POULIQUEN Signed-off-by: Patrick Delaunay Reviewed-by: Patrice Chotard --- drivers/remoteproc/stm32_copro.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/remoteproc/stm32_copro.c b/drivers/remoteproc/stm32_copro.c index da678cb329..dc87cb794e 100644 --- a/drivers/remoteproc/stm32_copro.c +++ b/drivers/remoteproc/stm32_copro.c @@ -139,19 +139,18 @@ static int stm32_copro_start(struct udevice *dev) /* * Once copro running, reset hold boot flag to avoid copro - * rebooting autonomously + * rebooting autonomously (error should never occur) */ ret = reset_assert(&priv->hold_boot); if (ret) dev_err(dev, "Unable to assert hold boot (ret=%d)\n", ret); - writel(ret ? TAMP_COPRO_STATE_OFF : TAMP_COPRO_STATE_CRUN, - TAMP_COPRO_STATE); - if (!ret) - /* Store rsc_address in bkp register */ - writel(priv->rsc_table_addr, TAMP_COPRO_RSC_TBL_ADDRESS); + /* indicates that copro is running */ + writel(TAMP_COPRO_STATE_CRUN, TAMP_COPRO_STATE); + /* Store rsc_address in bkp register */ + writel(priv->rsc_table_addr, TAMP_COPRO_RSC_TBL_ADDRESS); - return ret; + return 0; } /** -- 2.39.5