From 9da04c17a36f10d9ab8702751e1412f2edc91236 Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sun, 1 May 2022 18:43:28 +0200 Subject: [PATCH] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance. Signed-off-by: Marek Vasut Cc: Patrick Delaunay Cc: Patrice Chotard Cc: Ramon Fried Reviewed-by: Ramon Fried Reviewed-by: Patrick Delaunay Signed-off-by: Patrice Chotard --- configs/stm32mp15_dhcom_basic_defconfig | 1 - configs/stm32mp15_dhcor_basic_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig index ec955eae20..0ff015cae4 100644 --- a/configs/stm32mp15_dhcom_basic_defconfig +++ b/configs/stm32mp15_dhcom_basic_defconfig @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SPL_ENV_IS_NOWHERE=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_IP_DEFRAG=y -CONFIG_TFTP_BLOCKSIZE=1536 CONFIG_STM32_ADC=y CONFIG_SPL_BLOCK_CACHE=y CONFIG_DFU_MMC=y diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig index 387e068155..83614b9fc8 100644 --- a/configs/stm32mp15_dhcor_basic_defconfig +++ b/configs/stm32mp15_dhcor_basic_defconfig @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SPL_ENV_IS_NOWHERE=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_IP_DEFRAG=y -CONFIG_TFTP_BLOCKSIZE=1536 CONFIG_STM32_ADC=y CONFIG_SPL_BLOCK_CACHE=y CONFIG_DFU_MMC=y -- 2.39.5