From 0fe44dc676855ae195e6532e0bed56f53bd3346c Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 25 Apr 2021 08:39:32 +1200 Subject: [PATCH] binman: Correct testSplNoDtb() and Tpl also These two tests require an ELF image so that symbol information can be written into the SPL/TPL binary. At present they rely on other tests having set it up first, but every test must run independently. This can cause occasional errors in CI. Fix this by setting up the required files, as other tests do. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- tools/binman/ftest.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index 89fe6612e1..4db25e4335 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -1341,6 +1341,7 @@ class TestFunctional(unittest.TestCase): def testSplNoDtb(self): """Test that an image with spl/u-boot-spl-nodtb.bin can be created""" + self._SetupSplElf() data = self._DoReadFile('052_u_boot_spl_nodtb.dts') self.assertEqual(U_BOOT_SPL_NODTB_DATA, data[:len(U_BOOT_SPL_NODTB_DATA)]) @@ -4272,6 +4273,7 @@ class TestFunctional(unittest.TestCase): def testTplNoDtb(self): """Test that an image with tpl/u-boot-tpl-nodtb.bin can be created""" + self._SetupTplElf() data = self._DoReadFile('192_u_boot_tpl_nodtb.dts') self.assertEqual(U_BOOT_TPL_NODTB_DATA, data[:len(U_BOOT_TPL_NODTB_DATA)]) -- 2.39.5