]> git.dujemihanovic.xyz Git - u-boot.git/commit
Fix data abort caused by mis-aligning FIT data
authorReuben Dowle <reuben.dowle@4rf.com>
Tue, 1 Sep 2020 21:32:01 +0000 (21:32 +0000)
committerTom Rini <trini@konsulko.com>
Fri, 11 Sep 2020 21:13:56 +0000 (17:13 -0400)
commiteb39d8ba5f0d1468b01b89a2a464d18612d3ea76
tree93782078ccf62a0559a5b152171bb7ece6f5a717
parent1e2c5bb9e7f9fdad05a5b1f36c44da5cc430b8a9
Fix data abort caused by mis-aligning FIT data

Attempting to place device tree immediately after an image in memory can lead
to mis-aligned data accesses if that image size is not divisible by the
alignment requirements of the architecture.

Data aborts caused by this were observed on a custom Marvel A388 based system,
where the image was a uboot FIT file. The total size varies depending on the
uboot device tree size, which does not always lead to correct alignment.

The minimum alignment specified for ARM [1] and ARM64 [2] linux booting has been
used

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst#n126
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst#n45

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
common/spl/spl_fit.c