]> git.dujemihanovic.xyz Git - u-boot.git/commit
serial: Remove DM_FLAG_PRE_RELOC flag in various drivers
authorBin Meng <bmeng.cn@gmail.com>
Wed, 24 Oct 2018 13:36:36 +0000 (06:36 -0700)
committerSimon Glass <sjg@chromium.org>
Wed, 14 Nov 2018 17:16:28 +0000 (09:16 -0800)
commit4687919684e0e4390b9fc20d1809ecaa9dc3cb81
treee0cb2adcd74a9fe071035c2406d109e083129f50
parentd7a184d4a7d2706f091a3b708060f48a325234ef
serial: Remove DM_FLAG_PRE_RELOC flag in various drivers

When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be
bound before relocation. However due to a bug in the DM core,
the flag only takes effect when devices are statically declared
via U_BOOT_DEVICE(). This bug has been fixed recently by commit
"dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in
lists_bind_fdt()", but with the fix, it has a side effect that
all existing drivers that declared DM_FLAG_PRE_RELOC flag will
be bound before relocation now. This may expose potential boot
failure on some boards due to insufficient memory during the
pre-relocation stage.

To mitigate this potential impact, the following changes are
implemented:

- Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver
  only supports configuration from device tree (OF_CONTROL)
- Keep DM_FLAG_PRE_RELOC flag in the driver only if the device
  is statically declared via U_BOOT_DEVICE()
- Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for
  drivers that support both statically declared devices and
  configuration from device tree

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
26 files changed:
drivers/serial/altera_jtag_uart.c
drivers/serial/altera_uart.c
drivers/serial/arm_dcc.c
drivers/serial/atmel_usart.c
drivers/serial/ns16550.c
drivers/serial/serial_ar933x.c
drivers/serial/serial_arc.c
drivers/serial/serial_bcm283x_mu.c
drivers/serial/serial_bcm283x_pl011.c
drivers/serial/serial_bcm6345.c
drivers/serial/serial_efi.c
drivers/serial/serial_intel_mid.c
drivers/serial/serial_lpuart.c
drivers/serial/serial_meson.c
drivers/serial/serial_mvebu_a3700.c
drivers/serial/serial_mxc.c
drivers/serial/serial_omap.c
drivers/serial/serial_owl.c
drivers/serial/serial_pic32.c
drivers/serial/serial_pl01x.c
drivers/serial/serial_s5p.c
drivers/serial/serial_sh.c
drivers/serial/serial_sti_asc.c
drivers/serial/serial_stm32.c
drivers/serial/serial_xuartlite.c
drivers/serial/serial_zynq.c