From: Thomas Schaefer Date: Tue, 16 Jun 2020 20:03:52 +0000 (+0200) Subject: spl: fix ext4fs_mount return code handling X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=ea5003ad66b2c42d57496cbdf75218d0e15e41a5;p=u-boot.git spl: fix ext4fs_mount return code handling - Despite other ext4 filesystem functions, ext4fs_mount returns 0 in case of error. - This leads to u-boot crash in case that an SD card with valid partition table but without ext4 filesystem created in a partition is found on SD card. - Fix this by returning a proper error code of '-1' from spl_load_image_ext function in case of ext4fs_mount error. Signed-off-by: Thomas Schaefer [hthiery: slightly reword the commit message] Signed-off-by: Heiko Thiery Reviewed-by: Tom Rini --- diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c index 3898041d10..d73f062762 100644 --- a/common/spl/spl_ext.c +++ b/common/spl/spl_ext.c @@ -32,7 +32,7 @@ int spl_load_image_ext(struct spl_image_info *spl_image, #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT printf("%s: ext4fs mount err - %d\n", __func__, err); #endif - goto end; + return -1; } err = ext4fs_open(filename, &filelen);