From: Heinrich Schuchardt Date: Sun, 18 Mar 2018 11:01:06 +0000 (+0100) Subject: regulator: pbias: don't evaluate variable before assignment X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=c57b6b7090eab6a83c57175185e53166ab532675;p=u-boot.git regulator: pbias: don't evaluate variable before assignment We should not evaluate the value of reg before its value is set. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- diff --git a/drivers/power/regulator/pbias_regulator.c b/drivers/power/regulator/pbias_regulator.c index 116b7f480a..adf589b224 100644 --- a/drivers/power/regulator/pbias_regulator.c +++ b/drivers/power/regulator/pbias_regulator.c @@ -225,9 +225,6 @@ static int pbias_regulator_set_value(struct udevice *dev, int uV) int rc; u32 reg; - debug("Setting %s voltage to %s\n", p->name, - (reg & p->vmode) ? "3.0v" : "1.8v"); - rc = pmic_read(dev->parent, 0, (uint8_t *)®, sizeof(reg)); if (rc) return rc; @@ -239,6 +236,9 @@ static int pbias_regulator_set_value(struct udevice *dev, int uV) else return -EINVAL; + debug("Setting %s voltage to %s\n", p->name, + (reg & p->vmode) ? "3.0v" : "1.8v"); + return pmic_write(dev->parent, 0, (uint8_t *)®, sizeof(reg)); }