From: xypron.glpk@gmx.de Date: Tue, 16 May 2017 03:07:01 +0000 (+0200) Subject: net: core: avoid possible NULL pointer dereference X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=c08248d601e939ababe1642d11be63d0c14c7d1a;p=u-boot.git net: core: avoid possible NULL pointer dereference Checking if dev is NULL after dereferencing it does not make sense. Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger --- diff --git a/net/eth-uclass.c b/net/eth-uclass.c index c3cc3152a2..b659961a5d 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -181,7 +181,7 @@ int eth_get_dev_index(void) static int eth_write_hwaddr(struct udevice *dev) { - struct eth_pdata *pdata = dev->platdata; + struct eth_pdata *pdata; int ret = 0; if (!dev || !device_active(dev)) @@ -189,6 +189,7 @@ static int eth_write_hwaddr(struct udevice *dev) /* seq is valid since the device is active */ if (eth_get_ops(dev)->write_hwaddr && !eth_mac_skip(dev->seq)) { + pdata = dev->platdata; if (!is_valid_ethaddr(pdata->enetaddr)) { printf("\nError: %s address %pM illegal value\n", dev->name, pdata->enetaddr);