From: Ulf Magnusson Date: Tue, 30 Jan 2018 13:07:05 +0000 (+0100) Subject: usb: ulpi: kconfig: Remove meaningless choice default X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=a43aebee89acf57b4e22018f401cffc9fef4fd85;p=u-boot.git usb: ulpi: kconfig: Remove meaningless choice default 'default' on a choice refers to the symbol selected by default, not to the choice mode, so 'default n' is meaningless. No functional changes. Optional choices implicitly default to n mode (and there is no way to make them default to another mode). Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which prints the following warning: warning: the default selection n (undefined) of (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice I've added a corresponding warning to the C tools too, which is currently in linux-next: https://patchwork.kernel.org/patch/9983667/ Signed-off-by: Ulf Magnusson --- diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig index 329d2df3ed..001564d40c 100644 --- a/drivers/usb/ulpi/Kconfig +++ b/drivers/usb/ulpi/Kconfig @@ -3,7 +3,6 @@ comment "ULPI drivers" choice prompt "ULPI Viewport type" optional - default n help Select ULPI viewport (SoC-side interface to ULPI) implementation appropriate for the device if you want to communicate with