From: Udit Kumar Date: Thu, 29 Aug 2024 08:34:53 +0000 (+0530) Subject: ram: k3-ddrss: Handle error properly in lpddr4_start X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=541d21cf08ed318a6088d90a7db423b1e50e4038;p=u-boot.git ram: k3-ddrss: Handle error properly in lpddr4_start In lpddr4_start function error returned by lpddr4_enablepiinitiator may go undetected due to overwrite of return code. Add support to handle error in above case. Reported-by: Andreas Dannenberg Signed-off-by: Udit Kumar Reviewed-by: Bryan Brattlof --- diff --git a/drivers/ram/k3-ddrss/lpddr4.c b/drivers/ram/k3-ddrss/lpddr4.c index 11ef242a37..9f9abfeca4 100644 --- a/drivers/ram/k3-ddrss/lpddr4.c +++ b/drivers/ram/k3-ddrss/lpddr4.c @@ -155,10 +155,11 @@ u32 lpddr4_start(const lpddr4_privatedata *pd) u32 result = 0U; result = lpddr4_startsf(pd); - if (result == (u32)0) { + if (result == (u32)0) result = lpddr4_enablepiinitiator(pd); + if (result == (u32)0) result = lpddr4_startsequencecontroller(pd); - } + return result; }