From: Alper Nebi Yasak Date: Mon, 7 Feb 2022 22:08:06 +0000 (+0300) Subject: binman: Check missing bintools of Section subclasses X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=4897d331f37e1fd1c3a4ca599ea8093c4c977a09;p=u-boot.git binman: Check missing bintools of Section subclasses Binman can check for missing binary tools and prints warnings if anything required for an image is missing. The implementation of this for the Section entry only checks the subentries, presumably because Section does not use any binary tools itself. However, this means the check is also skipped for subclasses of Section which might need binary tools. Make sure missing binary tools are checked for subclasses of the Section entry type as well, by calling the parent class' implementation in the relevant Section method. Signed-off-by: Alper Nebi Yasak Reviewed-by: Simon Glass --- diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py index 706f6bd3e4..25159074ba 100644 --- a/tools/binman/etype/section.py +++ b/tools/binman/etype/section.py @@ -840,6 +840,7 @@ class Entry_section(Entry): Args: missing_list: List of Bintool objects to be added to """ + super().check_missing_bintools(missing_list) for entry in self._entries.values(): entry.check_missing_bintools(missing_list)