From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Sun, 7 Jan 2024 09:01:07 +0000 (+0100)
Subject: boot: superfluous assignment in bootflow_menu_new()
X-Git-Url: http://git.dujemihanovic.xyz/img/sics.gif?a=commitdiff_plain;h=3a7744ed1e5bd61b0bf83b7e1897184cb1c54f3f;p=u-boot.git

boot: superfluous assignment in bootflow_menu_new()

ret is assigned a value 0 which is never used but
is immediately overwritten in the next statement.

Addresses-Coverity-ID: 453304 ("Unused value")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c
index 7c1abe5772..16f9cd8f8c 100644
--- a/boot/bootflow_menu.c
+++ b/boot/bootflow_menu.c
@@ -120,7 +120,6 @@ int bootflow_menu_new(struct expo **expp)
 
 		if (ret < 0)
 			return log_msg_ret("itm", -EINVAL);
-		ret = 0;
 		priv->num_bootflows++;
 	}