]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Tue, 25 Apr 2023 14:19:35 +0000 (10:19 -0400)
committerStefano Babic <sbabic@denx.de>
Tue, 2 May 2023 08:57:32 +0000 (10:57 +0200)
It doesn't seem appropriate for arch/SOC to use a board-level
functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards
that need to do FDT fixup from using that feature.

Also, this code is completely dead and useless (from comments by
Rasmus Villemoes on the mailing list):

  - No in-tree imx8m-based board seems to set CONFIG_OF_BOARD_FIXUP
  - The nodes which that function wants to disable don't even exist in
    the U-Boot copy of imx8mp.dtsi.

This code was introduced in commit 35bb60787b88. It seems to be some
random import of code from downstream NXP U-Boot, with a commit
message that makes no sense in upstream context.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
arch/arm/mach-imx/imx8m/soc.c

index 20672ded9616d7f0806afb4815a694bd29f04f52..4705e6c1192636d5642efc938976dfaf6cbf5872 100644 (file)
@@ -1397,40 +1397,6 @@ usb_modify_speed:
 }
 #endif
 
-#ifdef CONFIG_OF_BOARD_FIXUP
-#ifndef CONFIG_SPL_BUILD
-int board_fix_fdt(void *fdt)
-{
-       if (is_imx8mpul()) {
-               int i = 0;
-               int nodeoff, ret;
-               const char *status = "disabled";
-               static const char * const dsi_nodes[] = {
-                       "/soc@0/bus@32c00000/mipi_dsi@32e60000",
-                       "/soc@0/bus@32c00000/lcd-controller@32e80000",
-                       "/dsi-host"
-               };
-
-               for (i = 0; i < ARRAY_SIZE(dsi_nodes); i++) {
-                       nodeoff = fdt_path_offset(fdt, dsi_nodes[i]);
-                       if (nodeoff > 0) {
-set_status:
-                               ret = fdt_setprop(fdt, nodeoff, "status", status,
-                                                 strlen(status) + 1);
-                               if (ret == -FDT_ERR_NOSPACE) {
-                                       ret = fdt_increase_size(fdt, 512);
-                                       if (!ret)
-                                               goto set_status;
-                               }
-                       }
-               }
-       }
-
-       return 0;
-}
-#endif
-#endif
-
 #if !CONFIG_IS_ENABLED(SYSRESET)
 void reset_cpu(void)
 {