]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mmc: renesas-sdhi: Fix error handling in rzg2l_sdhi_setup
authorPaul Barker <paul.barker.ct@bp.renesas.com>
Thu, 19 Oct 2023 14:50:38 +0000 (15:50 +0100)
committerMarek Vasut <marek.vasut+renesas@mailbox.org>
Fri, 27 Oct 2023 09:21:28 +0000 (11:21 +0200)
We should ensure that reset_free() is called in the error path.

Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Fixes: 93c811b7331b ("mmc: renesas-sdhi: Initialize module on RZ/G2L")
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
drivers/mmc/renesas-sdhi.c

index 1ea6e1066f2b881c3189b5a1f5df29918ae50a90..865efdd3218465079bac82415159d03a32ee4419 100644 (file)
@@ -998,7 +998,7 @@ static int rzg2l_sdhi_setup(struct udevice *dev)
        ret = reset_get_by_index(dev, 0, &rst);
        if (ret < 0) {
                dev_err(dev, "failed to get reset line\n");
-               goto err_reset;
+               goto err_get_reset;
        }
 
        ret = reset_deassert(&rst);
@@ -1016,6 +1016,8 @@ static int rzg2l_sdhi_setup(struct udevice *dev)
 err_tmio_probe:
        reset_assert(&rst);
 err_reset:
+       reset_free(&rst);
+err_get_reset:
        clk_disable(&aclk);
 err_aclk:
        clk_disable(&imclk2);