]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
binman: Increase size of TPL and SPL test data
authorSimon Glass <sjg@chromium.org>
Sat, 24 Aug 2019 13:23:04 +0000 (07:23 -0600)
committerSimon Glass <sjg@chromium.org>
Tue, 15 Oct 2019 14:40:02 +0000 (08:40 -0600)
At present these are large enough to hold 20 bytes of symbol data. Add
four more bytes so we can add another test.

Unfortunately at present this involves changing a few test files to make
room. We could adjust the test files to not specify sizes for entries.
Then we could make the tests check the actual sizes. But for now, leave it
as it is, since the effort is minor.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/binman/ftest.py
tools/binman/test/021_image_pad.dts
tools/binman/test/024_sorted.dts
tools/binman/test/028_pack_4gb_outside.dts
tools/binman/test/029_x86_rom.dts
tools/binman/test/053_symbols.dts
tools/binman/test/149_symbols_tpl.dts

index 6b0ab7fdc2a830a91ef8697265a2f5c35bcce731..5433c80e8e096e4b8dc6e020aee85c9fc6c360ff 100644 (file)
@@ -39,8 +39,8 @@ import tout
 # Contents of test files, corresponding to different entry types
 U_BOOT_DATA           = b'1234'
 U_BOOT_IMG_DATA       = b'img'
-U_BOOT_SPL_DATA       = b'56780123456789abcde'
-U_BOOT_TPL_DATA       = b'tpl9876543210fedcb'
+U_BOOT_SPL_DATA       = b'56780123456789abcdefghi'
+U_BOOT_TPL_DATA       = b'tpl9876543210fedcbazyw'
 BLOB_DATA             = b'89'
 ME_DATA               = b'0abcd'
 VGA_DATA              = b'vga'
@@ -922,7 +922,7 @@ class TestFunctional(unittest.TestCase):
         """Test that a basic x86 ROM can be created"""
         self._SetupSplElf()
         data = self._DoReadFile('029_x86_rom.dts')
-        self.assertEqual(U_BOOT_DATA + tools.GetBytes(0, 7) + U_BOOT_SPL_DATA +
+        self.assertEqual(U_BOOT_DATA + tools.GetBytes(0, 3) + U_BOOT_SPL_DATA +
                          tools.GetBytes(0, 2), data)
 
     def testPackX86RomMeNoDesc(self):
@@ -1236,7 +1236,7 @@ class TestFunctional(unittest.TestCase):
 
         self._SetupSplElf('u_boot_binman_syms')
         data = self._DoReadFile('053_symbols.dts')
-        sym_values = struct.pack('<LQL', 0, 24, 20)
+        sym_values = struct.pack('<LQL', 0, 28, 24)
         expected = (sym_values + U_BOOT_SPL_DATA[16:] +
                     tools.GetBytes(0xff, 1) + U_BOOT_DATA + sym_values +
                     U_BOOT_SPL_DATA[16:])
@@ -3305,7 +3305,7 @@ class TestFunctional(unittest.TestCase):
         self._SetupSplElf('u_boot_binman_syms')
         self._SetupTplElf('u_boot_binman_syms')
         data = self._DoReadFile('149_symbols_tpl.dts')
-        sym_values = struct.pack('<LQL', 4, 0x18, 0x30)
+        sym_values = struct.pack('<LQL', 4, 0x1c, 0x34)
         upto1 = 4 + len(U_BOOT_SPL_DATA)
         expected1 = tools.GetBytes(0xff, 4) + sym_values + U_BOOT_SPL_DATA[16:]
         self.assertEqual(expected1, data[:upto1])
@@ -3314,8 +3314,8 @@ class TestFunctional(unittest.TestCase):
         expected2 = tools.GetBytes(0xff, 1) + sym_values + U_BOOT_SPL_DATA[16:]
         self.assertEqual(expected2, data[upto1:upto2])
 
-        upto3 = 0x30 + len(U_BOOT_DATA)
-        expected3 = tools.GetBytes(0xff, 5) + U_BOOT_DATA
+        upto3 = 0x34 + len(U_BOOT_DATA)
+        expected3 = tools.GetBytes(0xff, 1) + U_BOOT_DATA
         self.assertEqual(expected3, data[upto2:upto3])
 
         expected4 = sym_values + U_BOOT_TPL_DATA[16:]
index c6516689d94c95e4e73b09a7c6ea5f7584cc9396..1ff8dab296fcff8c6237b996ad529f882c47fe7f 100644 (file)
@@ -10,7 +10,7 @@
                };
 
                u-boot {
-                       offset = <20>;
+                       offset = <24>;
                };
        };
 };
index d35d39f077d9825f3e03fc836512eedc7c8a4019..b79d9adf68271db3ee7d50e79af675adab09c283 100644 (file)
@@ -7,7 +7,7 @@
        binman {
                sort-by-offset;
                u-boot {
-                       offset = <22>;
+                       offset = <26>;
                };
 
                u-boot-spl {
index 2216abfb70c1de8a16c297b11a8a99cb6ad01a14..11a1f6059e263c8f1db70ad36e34ef456c89eed3 100644 (file)
@@ -13,7 +13,7 @@
                };
 
                u-boot-spl {
-                       offset = <0xffffffeb>;
+                       offset = <0xffffffe7>;
                };
        };
 };
index d5c69f9d4a9582608ec69b25e9c66fc8d06c0089..88aa007bbae19586402cdb2bab04eb6e56147d0b 100644 (file)
@@ -13,7 +13,7 @@
                };
 
                u-boot-spl {
-                       offset = <0xffffffeb>;
+                       offset = <0xffffffe7>;
                };
        };
 };
index 9f135676cb0743219a6598b44b43b89e6a3b7ad1..8af575158f57bc03f153048027f43aaacbd92285 100644 (file)
@@ -10,7 +10,7 @@
                };
 
                u-boot {
-                       offset = <20>;
+                       offset = <24>;
                };
 
                u-boot-spl2 {
index 087e10f29279e896385f83d903cce94d66ea70cb..dfc84af5e72f4e4659fa36aca67ad68f40b71244 100644 (file)
                };
 
                u-boot-spl2 {
-                       offset = <0x18>;
+                       offset = <0x1c>;
                        type = "u-boot-spl";
                };
 
                u-boot {
-                       offset = <0x30>;
+                       offset = <0x34>;
                };
 
                section {