]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: sun8i_emac: Drop unneeded cache invalidation before sending
authorAndre Przywara <andre.przywara@arm.com>
Mon, 6 Jul 2020 00:40:39 +0000 (01:40 +0100)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 21 Oct 2020 18:14:16 +0000 (23:44 +0530)
There is no reason to invalidate a TX descriptor before we are setting
it up, as we will only write to a field.

Remove the not needed invalidate_dcache_range() call.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Tested-by: Amit Singh Tomar <amittomer25@gmail.com> # Pine64+
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
drivers/net/sun8i_emac.c

index 335c85f3c2636972ac8e92d2f1db91a81d0251e7..45130e1ba1b100f3cd6a861aa3776f98ef558b7c 100644 (file)
@@ -624,9 +624,6 @@ static int sun8i_emac_eth_send(struct udevice *dev, void *packet, int length)
        uintptr_t data_end = data_start +
                roundup(length, ARCH_DMA_MINALIGN);
 
-       /* Invalidate entire buffer descriptor */
-       invalidate_dcache_range(desc_start, desc_end);
-
        desc_p->ctl_size = length | EMAC_DESC_CHAIN_SECOND;
 
        memcpy((void *)data_start, packet, length);