]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
test: dm: pci: Remove unnecessary steps in dm_test_pci_swapcase()
authorBin Meng <bmeng.cn@gmail.com>
Fri, 3 Aug 2018 08:14:38 +0000 (01:14 -0700)
committerSimon Glass <sjg@chromium.org>
Wed, 8 Aug 2018 11:49:31 +0000 (12:49 +0100)
The check on uclass_get_device() and device_active() is unnecessary
as the follow-up test operations will implicitly probe the driver.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
test/dm/pci.c

index 47b5d22af8fe05571371ead69a636b4f8f583f36..be1208cfbdf1f279e50cc0776f3a0081cd81f35b 100644 (file)
@@ -34,14 +34,12 @@ DM_TEST(dm_test_pci_busnum, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
 /* Test that we can use the swapcase device correctly */
 static int dm_test_pci_swapcase(struct unit_test_state *uts)
 {
-       struct udevice *emul, *swap;
+       struct udevice *swap;
        ulong io_addr, mem_addr;
        char *ptr;
 
        /* Check that asking for the device automatically fires up PCI */
-       ut_assertok(uclass_get_device(UCLASS_PCI_EMUL, 0, &emul));
        ut_assertok(dm_pci_bus_find_bdf(PCI_BDF(0, 0x1f, 0), &swap));
-       ut_assert(device_active(swap));
 
        /* First test I/O */
        io_addr = dm_pci_read_bar32(swap, 0);