]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
sandbox: sandbox_serial_pending depends on DM_VIDEO
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 21 Jan 2022 15:07:30 +0000 (16:07 +0100)
committerSimon Glass <sjg@chromium.org>
Tue, 25 Jan 2022 19:36:11 +0000 (12:36 -0700)
When building sandbox_defconfig with CONFIG_DM_VIDEO=n a link time error
occurs:

   in function `sandbox_serial_pending':
   drivers/serial/sandbox.c:101: undefined reference to `video_sync_all'

video_sync_all() is only defined if we have CONFIG_DM_VIDEO=y.

Calling this function in a serial driver looks quite hackish
but at least let's add the missing build constraint.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/serial/sandbox.c

index dbbcea5bb4db8d64526db7543089aaa22c1f946f..0b1756f5c0c8d16fd83fef6e6c716fc333d3e08e 100644 (file)
@@ -97,7 +97,7 @@ static int sandbox_serial_pending(struct udevice *dev, bool input)
                return 0;
 
        os_usleep(100);
-       if (!IS_ENABLED(CONFIG_SPL_BUILD))
+       if (IS_ENABLED(CONFIG_DM_VIDEO) && !IS_ENABLED(CONFIG_SPL_BUILD))
                video_sync_all();
        avail = membuff_putraw(&priv->buf, 100, false, &data);
        if (!avail)