]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
bus: ti-sysc: change in a normal driver
authorDario Binacchi <dariobin@libero.it>
Tue, 16 Mar 2021 20:51:44 +0000 (21:51 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 19 Mar 2021 14:35:20 +0000 (10:35 -0400)
The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, but
it is not allowed. This breaks of-platdata and makes the result
non-deterministic.

The driver does not need to be an uclass driver, so lets remove it. I
had turned it into an uclass driver because I thought wrongly it had to
call the dm_scan_fdt_dev routine to work properly, but some tests on the
board have shown otherwise.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/bus/ti-sysc.c

index 4e3d6103005649ceec3a74a24e86c3ae1cc2a38c..778c0654f6a3bae3f324a1f8c20115ae32ce9748 100644 (file)
@@ -148,12 +148,6 @@ clocks_err:
        return err;
 }
 
-UCLASS_DRIVER(ti_sysc) = {
-       .id = UCLASS_SIMPLE_BUS,
-       .name = "ti_sysc",
-       .post_bind = dm_scan_fdt_dev
-};
-
 U_BOOT_DRIVER(ti_sysc) = {
        .name = "ti_sysc",
        .id = UCLASS_SIMPLE_BUS,