]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
reset: Avoid a warning in devm_reset_bulk_get_by_node()
authorSimon Glass <sjg@chromium.org>
Fri, 14 May 2021 01:39:21 +0000 (19:39 -0600)
committerTom Rini <trini@konsulko.com>
Thu, 15 Jul 2021 22:42:05 +0000 (18:42 -0400)
The devres_alloc() function is intended to avoid the need for freeing
memory, although in practice it may not be enabled, thus leading to a true
leak.

Nevertheless this is intended. Add a comment to explain this.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 312952)
drivers/reset/reset-uclass.c

index 8caa616ed9f3ca7300a97b9320cdee7816063ff0..c09c009130db15855e373f926a34470c460c189e 100644 (file)
@@ -325,6 +325,8 @@ struct reset_ctl_bulk *devm_reset_bulk_get_by_node(struct udevice *dev,
        bulk = devres_alloc(devm_reset_bulk_release,
                            sizeof(struct reset_ctl_bulk),
                            __GFP_ZERO);
+
+       /* this looks like a leak, but devres takes care of it */
        if (unlikely(!bulk))
                return ERR_PTR(-ENOMEM);