]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
x86: broadwell: Don't bother probing the PCH for pinctrl
authorSimon Glass <sjg@chromium.org>
Sun, 17 Feb 2019 03:25:02 +0000 (20:25 -0700)
committerBin Meng <bmeng.cn@gmail.com>
Wed, 20 Feb 2019 07:27:10 +0000 (15:27 +0800)
At present the pinctrl probes the PCH but since it only uses it to obtain
a PCI address, this is no necessary. Avoiding this fixes one of the two
co-dependent loops in broadwell.

This driver really should be a proper pinctrl driver, but for now it
remains a syscon device.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
arch/x86/cpu/broadwell/pinctrl_broadwell.c

index 914ecfb3144e43ed5de2845bd4db63cf7abd8603..aa83abbf855edee56363fc75f97446cf06c94892 100644 (file)
@@ -16,6 +16,7 @@
 #include <asm/arch/gpio.h>
 #include <dt-bindings/gpio/x86-gpio.h>
 #include <dm/pinctrl.h>
+#include <dm/uclass-internal.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -214,7 +215,7 @@ static int broadwell_pinctrl_probe(struct udevice *dev)
        u32 gpiobase;
        int ret;
 
-       ret = uclass_first_device(UCLASS_PCH, &pch);
+       ret = uclass_find_first_device(UCLASS_PCH, &pch);
        if (ret)
                return ret;
        if (!pch)