]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
test: dm: spi: Fix sandbox dm_test_spi_find()
authorBin Meng <bmeng.cn@gmail.com>
Mon, 9 Sep 2019 13:00:03 +0000 (06:00 -0700)
committerJagan Teki <jagan@amarulasolutions.com>
Mon, 27 Jan 2020 16:57:21 +0000 (22:27 +0530)
Per sandbox_cs_info(), sandbox spi controller only supports chip
select 0. Current test case tries to locate devices on chip select
1, and any call to spi_get_bus_and_cs() or spi_cs_info() with cs
number 1 should not return 0.

This updates the test case to handle it correctly.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
test/dm/spi.c

index ffd789cd7fb382f4390604e6adc5634004552e78..8e417acc5f203665293126c27c4829f3c36cafa0 100644 (file)
@@ -77,10 +77,10 @@ static int dm_test_spi_find(struct unit_test_state *uts)
        /* We should be able to add something to another chip select */
        ut_assertok(sandbox_sf_bind_emul(state, busnum, cs_b, bus, node,
                                         "name"));
-       ut_assertok(spi_get_bus_and_cs(busnum, cs_b, speed, mode,
+       ut_asserteq(-EINVAL, spi_get_bus_and_cs(busnum, cs_b, speed, mode,
                                       "spi_flash_std", "name", &bus, &slave));
-       ut_assertok(spi_cs_info(bus, cs_b, &info));
-       ut_asserteq_ptr(info.dev, slave->dev);
+       ut_asserteq(-EINVAL, spi_cs_info(bus, cs_b, &info));
+       ut_asserteq_ptr(NULL, info.dev);
 
        /*
         * Since we are about to destroy all devices, we must tell sandbox