]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
acpi: Correct reset handling in acpi_device_add_power_res()
authorSimon Glass <sjg@chromium.org>
Wed, 4 Nov 2020 16:57:30 +0000 (09:57 -0700)
committerBin Meng <bmeng.cn@gmail.com>
Fri, 6 Nov 2020 01:51:30 +0000 (09:51 +0800)
If there is no reset line, this still emits ACPI code for the reset GPIO.
Fix it by updating the check.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
lib/acpi/acpi_device.c

index 95dfac583fc83ae8ff8117579284dc71a5d8dc56..c3439a59883570f4116ff77bccb4db3675fb0887 100644 (file)
@@ -422,7 +422,7 @@ int acpi_device_add_power_res(struct acpi_ctx *ctx, u32 tx_state_val,
 
        /* Method (_ON, 0, Serialized) */
        acpigen_write_method_serialized(ctx, "_ON", 0);
-       if (reset_gpio) {
+       if (has_reset) {
                ret = acpigen_set_enable_tx_gpio(ctx, tx_state_val, dw0_read,
                                                 dw0_write, &reset, true);
                if (ret)