]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
i2c: stm32: remove unused stop parameter in start & reload handling
authorAlain Volmat <alain.volmat@foss.st.com>
Mon, 12 Sep 2022 08:41:59 +0000 (10:41 +0200)
committerPatrick Delaunay <patrick.delaunay@foss.st.com>
Thu, 15 Sep 2022 12:58:57 +0000 (14:58 +0200)
Functions stm32_i2c_message_start and stm32_i2c_handle_reload
both get a stop boolean indicating if the transfer should end with
a STOP or not.  However no specific handling is needed in those
functions hence remove the parameter.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
drivers/i2c/stm32f7_i2c.c

index e3b4991eb89cd19f9e6049b41b4fa67cdd6c480a..8d680eea9b735a9b3f36c1c4380b77e6fe16c156 100644 (file)
@@ -282,7 +282,7 @@ static int stm32_i2c_check_device_busy(struct stm32_i2c_priv *i2c_priv)
 }
 
 static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv,
-                                   struct i2c_msg *msg, bool stop)
+                                   struct i2c_msg *msg)
 {
        struct stm32_i2c_regs *regs = i2c_priv->regs;
        u32 cr2 = readl(&regs->cr2);
@@ -325,7 +325,7 @@ static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv,
  */
 
 static void stm32_i2c_handle_reload(struct stm32_i2c_priv *i2c_priv,
-                                   struct i2c_msg *msg, bool stop)
+                                   struct i2c_msg *msg)
 {
        struct stm32_i2c_regs *regs = i2c_priv->regs;
        u32 cr2 = readl(&regs->cr2);
@@ -431,7 +431,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv,
        /* Add errors */
        mask |= STM32_I2C_ISR_ERRORS;
 
-       stm32_i2c_message_start(i2c_priv, msg, stop);
+       stm32_i2c_message_start(i2c_priv, msg);
 
        while (msg->len) {
                /*
@@ -469,7 +469,7 @@ static int stm32_i2c_message_xfer(struct stm32_i2c_priv *i2c_priv,
                        mask = msg->flags & I2C_M_RD ? STM32_I2C_ISR_RXNE :
                               STM32_I2C_ISR_TXIS | STM32_I2C_ISR_NACKF;
 
-                       stm32_i2c_handle_reload(i2c_priv, msg, stop);
+                       stm32_i2c_handle_reload(i2c_priv, msg);
                } else if (!bytes_to_rw) {
                        /* Wait until TC flag is set */
                        mask = STM32_I2C_ISR_TC;