drivers: firmware: Handle error case in the zynqmp_pm_feature

Unhandled error coming from xilinx_pm_request() but return
value is not read back that's why getting sparse warning
as below:
warning: variable 'ret' set but not used [-Wunused-but-set-variable].
In case of error return the "ret" value.

Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Link: https://lore.kernel.org/r/20231011025647.17200-1-venkatesh.abbarapu@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>

diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
index 43fb7fa7787e5ef62b5bc3ff521bc9bcf35cdafd..8ea15c7ed3390c40351817a68ac769cff75ceaff 100644 (file)
--- a/drivers/firmware/firmware-zynqmp.c
+++ b/drivers/firmware/firmware-zynqmp.c
@@ -203,6 +203,8 @@ int zynqmp_pm_feature(const u32 api_id)
        /* Check feature check API version */
        ret = xilinx_pm_request(PM_FEATURE_CHECK, api_id, 0, 0, 0,
                                ret_payload);
+       if (ret)
+               return ret;
 
        /* Return feature check version */
        return ret_payload[1] & FIRMWARE_VERSION_MASK;