x86: irq: Move irq_router to a per driver priv

At present irq_router is declared as a static struct irq_router in
arch/x86/cpu/irq.c. Since it's a driver control block, it makes sense
to move it to a per driver priv. Adjust existing APIs to accept an
additional parameter of irq_router's udevice.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>

diff --git a/arch/x86/cpu/irq.c b/arch/x86/cpu/irq.c
index cc0297fa51f607dcc0bb2cac0cea65eb36a0e52a..fea6f65c7afddd1c694fa843adae17e921d23dde 100644 (file)
--- a/arch/x86/cpu/irq.c
+++ b/arch/x86/cpu/irq.c
@@ -16,19 +16,18 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-static struct irq_router irq_router;
 static struct irq_routing_table *pirq_routing_table;
 
-bool pirq_check_irq_routed(int link, u8 irq)
+bool pirq_check_irq_routed(struct udevice *dev, int link, u8 irq)
 {
+       struct irq_router *priv = dev_get_priv(dev);
        u8 pirq;
-       int base = irq_router.link_base;
+       int base = priv->link_base;
 
-       if (irq_router.config == PIRQ_VIA_PCI)
-               pirq = x86_pci_read_config8(irq_router.bdf,
-                                           LINK_N2V(link, base));
+       if (priv->config == PIRQ_VIA_PCI)
+               pirq = x86_pci_read_config8(priv->bdf, LINK_N2V(link, base));
        else
-               pirq = readb(irq_router.ibase + LINK_N2V(link, base));
+               pirq = readb(priv->ibase + LINK_N2V(link, base));
 
        pirq &= 0xf;
 
@@ -39,24 +38,26 @@ bool pirq_check_irq_routed(int link, u8 irq)
        return pirq == irq ? true : false;
 }
 
-int pirq_translate_link(int link)
+int pirq_translate_link(struct udevice *dev, int link)
 {
-       return LINK_V2N(link, irq_router.link_base);
+       struct irq_router *priv = dev_get_priv(dev);
+
+       return LINK_V2N(link, priv->link_base);
 }
 
-void pirq_assign_irq(int link, u8 irq)
+void pirq_assign_irq(struct udevice *dev, int link, u8 irq)
 {
-       int base = irq_router.link_base;
+       struct irq_router *priv = dev_get_priv(dev);
+       int base = priv->link_base;
 
        /* IRQ# 0/1/2/8/13 are reserved */
        if (irq < 3 || irq == 8 || irq == 13)
                return;
 
-       if (irq_router.config == PIRQ_VIA_PCI)
-               x86_pci_write_config8(irq_router.bdf,
-                                     LINK_N2V(link, base), irq);
+       if (priv->config == PIRQ_VIA_PCI)
+               x86_pci_write_config8(priv->bdf, LINK_N2V(link, base), irq);
        else
-               writeb(irq, irq_router.ibase + LINK_N2V(link, base));
+               writeb(irq, priv->ibase + LINK_N2V(link, base));
 }
 
 static struct irq_info *check_dup_entry(struct irq_info *slot_base,
@@ -74,17 +75,18 @@ static struct irq_info *check_dup_entry(struct irq_info *slot_base,
        return (i == entry_num) ? NULL : slot;
 }
 
-static inline void fill_irq_info(struct irq_info *slot, int bus, int device,
-                                int pin, int pirq)
+static inline void fill_irq_info(struct irq_router *priv, struct irq_info *slot,
+                                int bus, int device, int pin, int pirq)
 {
        slot->bus = bus;
        slot->devfn = (device << 3) | 0;
-       slot->irq[pin - 1].link = LINK_N2V(pirq, irq_router.link_base);
-       slot->irq[pin - 1].bitmap = irq_router.irq_mask;
+       slot->irq[pin - 1].link = LINK_N2V(pirq, priv->link_base);
+       slot->irq[pin - 1].bitmap = priv->irq_mask;
 }
 
 static int create_pirq_routing_table(struct udevice *dev)
 {
+       struct irq_router *priv = dev_get_priv(dev);
        const void *blob = gd->fdt_blob;
        int node;
        int len, count;
@@ -98,15 +100,15 @@ static int create_pirq_routing_table(struct udevice *dev)
        node = dev->of_offset;
 
        /* extract the bdf from fdt_pci_addr */
-       irq_router.bdf = dm_pci_get_bdf(dev->parent);
+       priv->bdf = dm_pci_get_bdf(dev->parent);
 
        ret = fdt_find_string(blob, node, "intel,pirq-config", "pci");
        if (!ret) {
-               irq_router.config = PIRQ_VIA_PCI;
+               priv->config = PIRQ_VIA_PCI;
        } else {
                ret = fdt_find_string(blob, node, "intel,pirq-config", "ibase");
                if (!ret)
-                       irq_router.config = PIRQ_VIA_IBASE;
+                       priv->config = PIRQ_VIA_IBASE;
                else
                        return -EINVAL;
        }
@@ -114,12 +116,12 @@ static int create_pirq_routing_table(struct udevice *dev)
        ret = fdtdec_get_int(blob, node, "intel,pirq-link", -1);
        if (ret == -1)
                return ret;
-       irq_router.link_base = ret;
+       priv->link_base = ret;
 
-       irq_router.irq_mask = fdtdec_get_int(blob, node,
-                                            "intel,pirq-mask", PIRQ_BITMAP);
+       priv->irq_mask = fdtdec_get_int(blob, node,
+                                       "intel,pirq-mask", PIRQ_BITMAP);
 
-       if (irq_router.config == PIRQ_VIA_IBASE) {
+       if (priv->config == PIRQ_VIA_IBASE) {
                int ibase_off;
 
                ibase_off = fdtdec_get_int(blob, node, "intel,ibase-offset", 0);
@@ -136,9 +138,8 @@ static int create_pirq_routing_table(struct udevice *dev)
                 *   2) memory range decoding is enabled.
                 * Hence we don't do any santify test here.
                 */
-               irq_router.ibase = x86_pci_read_config32(irq_router.bdf,
-                                                        ibase_off);
-               irq_router.ibase &= ~0xf;
+               priv->ibase = x86_pci_read_config32(priv->bdf, ibase_off);
+               priv->ibase &= ~0xf;
        }
 
        cell = fdt_getprop(blob, node, "intel,pirq-routing", &len);
@@ -153,9 +154,8 @@ static int create_pirq_routing_table(struct udevice *dev)
        /* Populate the PIRQ table fields */
        rt->signature = PIRQ_SIGNATURE;
        rt->version = PIRQ_VERSION;
-       rt->rtr_bus = PCI_BUS(irq_router.bdf);
-       rt->rtr_devfn = (PCI_DEV(irq_router.bdf) << 3) |
-                       PCI_FUNC(irq_router.bdf);
+       rt->rtr_bus = PCI_BUS(priv->bdf);
+       rt->rtr_devfn = (PCI_DEV(priv->bdf) << 3) | PCI_FUNC(priv->bdf);
        rt->rtr_vendor = PCI_VENDOR_ID_INTEL;
        rt->rtr_device = PCI_DEVICE_ID_INTEL_ICH7_31;
 
@@ -192,7 +192,7 @@ static int create_pirq_routing_table(struct udevice *dev)
                                 * routing information in the device tree.
                                 */
                                if (slot->irq[pr.pin - 1].link !=
-                                       LINK_N2V(pr.pirq, irq_router.link_base))
+                                       LINK_N2V(pr.pirq, priv->link_base))
                                        debug("WARNING: Inconsistent PIRQ routing information\n");
                                continue;
                        }
@@ -200,8 +200,8 @@ static int create_pirq_routing_table(struct udevice *dev)
                        slot = slot_base + irq_entries++;
                }
                debug("writing INT%c\n", 'A' + pr.pin - 1);
-               fill_irq_info(slot, PCI_BUS(pr.bdf), PCI_DEV(pr.bdf), pr.pin,
-                             pr.pirq);
+               fill_irq_info(priv, slot, PCI_BUS(pr.bdf), PCI_DEV(pr.bdf),
+                             pr.pin, pr.pirq);
        }
 
        rt->size = irq_entries * sizeof(struct irq_info) + 32;
@@ -221,7 +221,7 @@ int irq_router_common_init(struct udevice *dev)
                return ret;
        }
        /* Route PIRQ */
-       pirq_route_irqs(pirq_routing_table->slots,
+       pirq_route_irqs(dev, pirq_routing_table->slots,
                        get_irq_slot_count(pirq_routing_table));
 
        return 0;
@@ -250,6 +250,7 @@ U_BOOT_DRIVER(irq_router_drv) = {
        .id             = UCLASS_IRQ,
        .of_match       = irq_router_ids,
        .probe          = irq_router_probe,
+       .priv_auto_alloc_size = sizeof(struct irq_router),
 };
 
 UCLASS_DRIVER(irq) = {

diff --git a/arch/x86/include/asm/pirq_routing.h b/arch/x86/include/asm/pirq_routing.h
index ddc08e11d5efa4b90340a265398a56091646d6db..0afcb4615e9c9fd37845b03d61e3693cbecbca9a 100644 (file)
--- a/arch/x86/include/asm/pirq_routing.h
+++ b/arch/x86/include/asm/pirq_routing.h
@@ -72,12 +72,13 @@ static inline int get_irq_slot_count(struct irq_routing_table *rt)
  * Note: this function should be provided by the platform codes, as the
  * implementation of interrupt router may be different.
  *
+ * @dev:       irq router's udevice
  * @link:      link number which represents a PIRQ
  * @irq:       the 8259 IRQ number
  * @return:    true if the irq is already routed to 8259 for a given link,
  *             false elsewise
  */
-bool pirq_check_irq_routed(int link, u8 irq);
+bool pirq_check_irq_routed(struct udevice *dev, int link, u8 irq);
 
 /**
  * pirq_translate_link() - Translate a link value
@@ -89,10 +90,11 @@ bool pirq_check_irq_routed(int link, u8 irq);
  * Note: this function should be provided by the platform codes, as the
  * implementation of interrupt router may be different.
  *
+ * @dev:       irq router's udevice
  * @link:      platform-specific link value
  * @return:    link number which represents a PIRQ
  */
-int pirq_translate_link(int link);
+int pirq_translate_link(struct udevice *dev, int link);
 
 /**
  * pirq_assign_irq() - Assign an IRQ to a PIRQ link
@@ -103,10 +105,11 @@ int pirq_translate_link(int link);
  * Note: this function should be provided by the platform codes, as the
  * implementation of interrupt router may be different.
  *
+ * @dev:       irq router's udevice
  * @link:      link number which represents a PIRQ
  * @irq:       IRQ to which the PIRQ is routed
  */
-void pirq_assign_irq(int link, u8 irq);
+void pirq_assign_irq(struct udevice *dev, int link, u8 irq);
 
 /**
  * pirq_route_irqs() - Route PIRQs to 8259 PIC
@@ -117,10 +120,11 @@ void pirq_assign_irq(int link, u8 irq);
  * The configuration source is taken from a struct irq_info table, the format
  * of which is defined in PIRQ routing table spec and PCI BIOS spec.
  *
+ * @dev:       irq router's udevice
  * @irq:       pointer to the base address of the struct irq_info
  * @num:       number of entries in the struct irq_info
  */
-void pirq_route_irqs(struct irq_info *irq, int num);
+void pirq_route_irqs(struct udevice *dev, struct irq_info *irq, int num);
 
 /**
  * copy_pirq_routing_table() - Copy a PIRQ routing table

diff --git a/arch/x86/lib/pirq_routing.c b/arch/x86/lib/pirq_routing.c
index ba4116908c92017b9267215bf090e1ea30dce220..3cc6adbbbbb9714bbdc4f51911d66d63d371fa32 100644 (file)
--- a/arch/x86/lib/pirq_routing.c
+++ b/arch/x86/lib/pirq_routing.c
@@ -14,7 +14,7 @@
 
 static bool irq_already_routed[16];
 
-static u8 pirq_get_next_free_irq(u8 *pirq, u16 bitmap)
+static u8 pirq_get_next_free_irq(struct udevice *dev, u8 *pirq, u16 bitmap)
 {
        int i, link;
        u8 irq = 0;
@@ -33,7 +33,7 @@ static u8 pirq_get_next_free_irq(u8 *pirq, u16 bitmap)
                        continue;
 
                for (link = 0; link < CONFIG_MAX_PIRQ_LINKS; link++) {
-                       if (pirq_check_irq_routed(link, irq)) {
+                       if (pirq_check_irq_routed(dev, link, irq)) {
                                irq_already_routed[irq] = true;
                                break;
                        }
@@ -52,7 +52,7 @@ static u8 pirq_get_next_free_irq(u8 *pirq, u16 bitmap)
        return irq;
 }
 
-void pirq_route_irqs(struct irq_info *irq, int num)
+void pirq_route_irqs(struct udevice *dev, struct irq_info *irq, int num)
 {
        unsigned char irq_slot[MAX_INTX_ENTRIES];
        unsigned char pirq[CONFIG_MAX_PIRQ_LINKS];
@@ -80,11 +80,11 @@ void pirq_route_irqs(struct irq_info *irq, int num)
                        }
 
                        /* translate link value to link number */
-                       link = pirq_translate_link(link);
+                       link = pirq_translate_link(dev, link);
 
                        /* yet not routed */
                        if (!pirq[link]) {
-                               irq = pirq_get_next_free_irq(pirq, bitmap);
+                               irq = pirq_get_next_free_irq(dev, pirq, bitmap);
                                pirq[link] = irq;
                        } else {
                                irq = pirq[link];
@@ -94,7 +94,7 @@ void pirq_route_irqs(struct irq_info *irq, int num)
                        irq_slot[intx] = irq;
 
                        /* Assign IRQ in the interrupt router */
-                       pirq_assign_irq(link, irq);
+                       pirq_assign_irq(dev, link, irq);
                }
 
                /* Bus, device, slots IRQs for {A,B,C,D} */