]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
gpio: qcom_pmic: 1-based GPIOs
authorCaleb Connolly <caleb.connolly@linaro.org>
Mon, 26 Feb 2024 17:26:13 +0000 (17:26 +0000)
committerCaleb Connolly <caleb.connolly@linaro.org>
Fri, 1 Mar 2024 14:44:36 +0000 (14:44 +0000)
Qualcomm PMICs number their GPIOs starting from 1, implement a custom
.xlate method to handle this.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Tested-by: Sumit Garg <sumit.garg@linaro.org> #qcs404
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
drivers/gpio/qcom_pmic_gpio.c

index 6167c8411678944ad359788eecacb8fa2184d021..2a4fef8d28cb9eed0560af7edc27a65bad96bdd4 100644 (file)
@@ -209,12 +209,34 @@ static int qcom_gpio_set_value(struct udevice *dev, unsigned offset,
                                       REG_CTL_OUTPUT_MASK, !!value);
 }
 
+static int qcom_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
+                          struct ofnode_phandle_args *args)
+{
+       struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+
+       if (args->args_count < 1)
+               return -EINVAL;
+
+       /* GPIOs in DT are 1-based */
+       desc->offset = args->args[0] - 1;
+       if (desc->offset >= uc_priv->gpio_count)
+               return -EINVAL;
+
+       if (args->args_count < 2)
+               return 0;
+
+       desc->flags = gpio_flags_xlate(args->args[1]);
+
+       return 0;
+}
+
 static const struct dm_gpio_ops qcom_gpio_ops = {
        .direction_input        = qcom_gpio_direction_input,
        .direction_output       = qcom_gpio_direction_output,
        .get_value              = qcom_gpio_get_value,
        .set_value              = qcom_gpio_set_value,
        .get_function           = qcom_gpio_get_function,
+       .xlate                  = qcom_gpio_xlate,
 };
 
 static int qcom_gpio_probe(struct udevice *dev)