]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
rockchip: mmc: rockchip_dw_mmc: fix ciu clock index
authorJohan Jonker <jbx6244@gmail.com>
Sat, 9 Apr 2022 16:55:08 +0000 (18:55 +0200)
committerKever Yang <kever.yang@rock-chips.com>
Mon, 18 Apr 2022 03:25:13 +0000 (11:25 +0800)
The document rockchip-dw-mshc.yaml decribes a maximum of 4 clocks.
In the rockchip_dw_mmc driver the clock name in use was "fixed"
to "ciu" with index 1, but later reverted back to index 0.
The clock drivers can handle both, but the calling driver
should submit correct data as a standard practice.
Fix the "ciu" clock index by setting it back to 1.

  clock-names:
    minItems: 2
    items:
      - const: biu
      - const: ciu
      - const: ciu-drive
      - const: ciu-sample

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/mmc/rockchip_dw_mmc.c

index 7f8dea1e343d70b6ff0a77babc695d482a4e8622..be065ec0c34bd08a1c42a560afeecaae43228b3f 100644 (file)
@@ -123,11 +123,11 @@ static int rockchip_dwmmc_probe(struct udevice *dev)
        priv->minmax[0] = 400000;  /*  400 kHz */
        priv->minmax[1] = dtplat->max_frequency;
 
-       ret = clk_get_by_phandle(dev, dtplat->clocks, &priv->clk);
+       ret = clk_get_by_phandle(dev, &dtplat->clocks[1], &priv->clk);
        if (ret < 0)
                return ret;
 #else
-       ret = clk_get_by_index(dev, 0, &priv->clk);
+       ret = clk_get_by_index(dev, 1, &priv->clk);
        if (ret < 0)
                return ret;
 #endif