]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
km/ls102xa: use unused scratchrw4 address for post word
authorAleksandar Gerasimovski <aleksandar.gerasimovski@hitachienergy.com>
Tue, 16 Nov 2021 13:13:35 +0000 (13:13 +0000)
committerPriyanka Jain <priyanka.jain@nxp.com>
Tue, 1 Feb 2022 09:38:07 +0000 (15:08 +0530)
The SCRATCHRW4 is only used in secure boot scenario that is unsupported by
our design, so this address can be stolen for storing POST status.
The SCRATCHRW4 is initialized to zero at core rest.

Using a DDR address was unfortunate choice, the DDR at boot time has a
random contend and it happens that sometimes is matching POST magic number.
This behavior can lead to undefined POST behavior and u-boot ending in
failbootcmd command.

Signed-off-by: Aleksandar Gerasimovski <aleksandar.gerasimovski@hitachienergy.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c

index a37d11160e886982fc05ffec82d8d1bd41dea32b..467f1109517b45351381c2b50daba5ff8a1c8e2c 100644 (file)
@@ -162,19 +162,18 @@ int post_hotkeys_pressed(void)
        return qrio_get_selftest_pin();
 }
 
+/* POST word is located in the unused SCRATCHRW4 register */
+#define CCSR_SCRATCHRW4_ADDR           0x1ee020c
+
 ulong post_word_load(void)
 {
-       /* POST word is located at the beginning of reserved physical RAM */
-       void *addr = (void *)(CONFIG_SYS_SDRAM_BASE +
-                               gd->ram_size - CONFIG_KM_RESERVED_PRAM + 8);
+       void *addr = (void *)CCSR_SCRATCHRW4_ADDR;
        return in_le32(addr);
 }
 
 void post_word_store(ulong value)
 {
-       /* POST word is located at the beginning of reserved physical RAM */
-       void *addr = (void *)(CONFIG_SYS_SDRAM_BASE +
-                               gd->ram_size - CONFIG_KM_RESERVED_PRAM + 8);
+       void *addr = (void *)CCSR_SCRATCHRW4_ADDR;
        out_le32(addr, value);
 }