POST: add new memory regions test

This test is similar to the actual POST memory test but quicker and
far less complete. It checks the address and data lines and then only
tests some regularly placed sub regions of the RAM.
This can be useful when we want to test the RAM but we do not have enough
time to run the full memory test.

The POST memory test code was rearranged in order to avoid code duplication
between the two tests but the memory test functionnality remains the same.

Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Ackey-by: Mike Frysinger <vapier@gentoo.org>

diff --git a/include/post.h b/include/post.h
index e783b94d2ebf09feacb5ef20276bc3b61e31c4c9..ac93f439692f95f4cdc6e8fb57f276b9bc3e5f29 100644 (file)
--- a/include/post.h
+++ b/include/post.h
@@ -196,6 +196,7 @@ extern int memory_post_test(int flags);
 #define CONFIG_SYS_POST_CODEC          0x00200000
 #define CONFIG_SYS_POST_COPROC         0x00400000
 #define CONFIG_SYS_POST_FLASH          0x00800000
+#define CONFIG_SYS_POST_MEM_REGIONS    0x01000000
 
 #endif /* CONFIG_POST */
 

diff --git a/post/drivers/memory.c b/post/drivers/memory.c
index 69c5dbec45339d90c14496751fd2f4d8da7d78e8..69973c0f4427bd7be4a6c5e923967a567c411b33 100644 (file)
--- a/post/drivers/memory.c
+++ b/post/drivers/memory.c
@@ -153,7 +153,7 @@
 #include <post.h>
 #include <watchdog.h>
 
-#if CONFIG_POST & CONFIG_SYS_POST_MEMORY
+#if CONFIG_POST & (CONFIG_SYS_POST_MEMORY | CONFIG_SYS_POST_MEM_REGIONS)
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -413,23 +413,29 @@ static int memory_post_test4(unsigned long start, unsigned long size)
        return ret;
 }
 
-static int memory_post_tests(unsigned long start, unsigned long size)
+static int memory_post_test_lines(unsigned long start, unsigned long size)
 {
        int ret = 0;
 
-       if (!ret)
-               ret = memory_post_dataline((unsigned long long *)start);
+       ret = memory_post_dataline((unsigned long long *)start);
        WATCHDOG_RESET();
        if (!ret)
                ret = memory_post_addrline((ulong *)start, (ulong *)start,
-                                               size);
+                               size);
        WATCHDOG_RESET();
        if (!ret)
-               ret = memory_post_addrline((ulong *)(start + size - 8),
-                                           (ulong *)start, size);
+               ret = memory_post_addrline((ulong *)(start+size-8),
+                               (ulong *)start, size);
        WATCHDOG_RESET();
-       if (!ret)
-               ret = memory_post_test1(start, size, 0x00000000);
+
+       return ret;
+}
+
+static int memory_post_test_patterns(unsigned long start, unsigned long size)
+{
+       int ret = 0;
+
+       ret = memory_post_test1(start, size, 0x00000000);
        WATCHDOG_RESET();
        if (!ret)
                ret = memory_post_test1(start, size, 0xffffffff);
@@ -453,6 +459,33 @@ static int memory_post_tests(unsigned long start, unsigned long size)
        return ret;
 }
 
+static int memory_post_test_regions(unsigned long start, unsigned long size)
+{
+       unsigned long i;
+       int ret = 0;
+
+       for (i = 0; i < (size >> 20) && (!ret); i++) {
+               if (!ret)
+                       ret = memory_post_test_patterns(i << 20, 0x800);
+               if (!ret)
+                       ret = memory_post_test_patterns((i << 20) + 0xff800,
+                               0x800);
+       }
+
+       return ret;
+}
+
+static int memory_post_tests(unsigned long start, unsigned long size)
+{
+       int ret = 0;
+
+       ret = memory_post_test_lines(start, size);
+       if (!ret)
+               ret = memory_post_test_patterns(start, size);
+
+       return ret;
+}
+
 /*
  * !! this is only valid, if you have contiguous memory banks !!
  */
@@ -490,6 +523,21 @@ void arch_memory_failure_handle(void)
        return;
 }
 
+int memory_regions_post_test(int flags)
+{
+       int ret = 0;
+       phys_addr_t phys_offset = 0;
+       u32 memsize, vstart;
+
+       arch_memory_test_prepare(&vstart, &memsize, &phys_offset);
+
+       ret = memory_post_test_lines(vstart, memsize);
+       if (!ret)
+               ret = memory_post_test_regions(vstart, memsize);
+
+       return ret;
+}
+
 int memory_post_test(int flags)
 {
        int ret = 0;
@@ -502,15 +550,7 @@ int memory_post_test(int flags)
                if (flags & POST_SLOWTEST) {
                        ret = memory_post_tests(vstart, memsize);
                } else {                        /* POST_NORMAL */
-                       unsigned long i;
-                       for (i = 0; i < (memsize >> 20) && !ret; i++) {
-                               if (!ret)
-                                       ret = memory_post_tests(vstart +
-                                               (i << 20), 0x800);
-                               if (!ret)
-                                       ret = memory_post_tests(vstart +
-                                               (i << 20) + 0xff800, 0x800);
-                       }
+                       ret = memory_post_test_regions(vstart, memsize);
                }
        } while (!ret &&
                !arch_memory_test_advance(&vstart, &memsize, &phys_offset));
@@ -522,4 +562,4 @@ int memory_post_test(int flags)
        return ret;
 }
 
-#endif /* CONFIG_POST & CONFIG_SYS_POST_MEMORY */
+#endif /* CONFIG_POST&(CONFIG_SYS_POST_MEMORY|CONFIG_SYS_POST_MEM_REGIONS) */

diff --git a/post/tests.c b/post/tests.c
index 725f80b96bb412b9601a5b9d4852f875e54d15ae..98af98049ab94a669a69543cb3268ff3b9353ae4 100644 (file)
--- a/post/tests.c
+++ b/post/tests.c
@@ -57,6 +57,7 @@ extern int sysmon1_post_test(int flags);
 extern int coprocessor_post_test(int flags);
 extern int led_post_test(int flags);
 extern int button_post_test(int flags);
+extern int memory_regions_post_test(int flags);
 
 extern int sysmon_init_f (void);
 
@@ -318,6 +319,18 @@ struct post_test post_list[] =
        CONFIG_SYS_POST_FLASH
     },
 #endif
+#if CONFIG_POST & CONFIG_SYS_POST_MEM_REGIONS
+    {
+       "Memory regions test",
+       "mem_regions",
+       "This test checks regularly placed regions of the RAM.",
+       POST_ROM | POST_SLOWTEST | POST_PREREL,
+       &memory_regions_post_test,
+       NULL,
+       NULL,
+       CONFIG_SYS_POST_MEM_REGIONS
+    },
+#endif
 };
 
 unsigned int post_list_size = ARRAY_SIZE(post_list);