]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
cmd: blk_common: Use macros for the return values
authorBin Meng <bmeng@tinylab.org>
Tue, 26 Sep 2023 08:43:40 +0000 (16:43 +0800)
committerTom Rini <trini@konsulko.com>
Tue, 10 Oct 2023 20:25:48 +0000 (16:25 -0400)
Avoid using magic number 0/1 for the command result.

Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
cmd/blk_common.c

index 9f9d4327a99683679deaf5855a41f0c6c880c81f..ad9b16dc098d3a99cce8d3e9c655ab21329e364b 100644 (file)
@@ -25,18 +25,18 @@ int blk_common_cmd(int argc, char *const argv[], enum uclass_id uclass_id,
        case 2:
                if (strncmp(argv[1], "inf", 3) == 0) {
                        blk_list_devices(uclass_id);
-                       return 0;
+                       return CMD_RET_SUCCESS;
                } else if (strncmp(argv[1], "dev", 3) == 0) {
                        if (blk_print_device_num(uclass_id, *cur_devnump)) {
                                printf("\nno %s devices available\n", if_name);
                                return CMD_RET_FAILURE;
                        }
-                       return 0;
+                       return CMD_RET_SUCCESS;
                } else if (strncmp(argv[1], "part", 4) == 0) {
                        if (blk_list_part(uclass_id))
                                printf("\nno %s partition table available\n",
                                       if_name);
-                       return 0;
+                       return CMD_RET_SUCCESS;
                }
                return CMD_RET_USAGE;
        case 3:
@@ -49,7 +49,7 @@ int blk_common_cmd(int argc, char *const argv[], enum uclass_id uclass_id,
                        } else {
                                return CMD_RET_FAILURE;
                        }
-                       return 0;
+                       return CMD_RET_SUCCESS;
                } else if (strncmp(argv[1], "part", 4) == 0) {
                        int dev = (int)dectoul(argv[2], NULL);
 
@@ -58,7 +58,7 @@ int blk_common_cmd(int argc, char *const argv[], enum uclass_id uclass_id,
                                       if_name, dev);
                                return CMD_RET_FAILURE;
                        }
-                       return 0;
+                       return CMD_RET_SUCCESS;
                }
                return CMD_RET_USAGE;
 
@@ -80,7 +80,7 @@ int blk_common_cmd(int argc, char *const argv[], enum uclass_id uclass_id,
 
                        printf("%ld blocks read: %s\n", n,
                               n == cnt ? "OK" : "ERROR");
-                       return n == cnt ? 0 : 1;
+                       return n == cnt ? CMD_RET_SUCCESS : CMD_RET_FAILURE;
                } else if (strcmp(argv[1], "write") == 0) {
                        phys_addr_t paddr = hextoul(argv[2], NULL);
                        lbaint_t blk = hextoul(argv[3], NULL);
@@ -98,7 +98,7 @@ int blk_common_cmd(int argc, char *const argv[], enum uclass_id uclass_id,
 
                        printf("%ld blocks written: %s\n", n,
                               n == cnt ? "OK" : "ERROR");
-                       return n == cnt ? 0 : 1;
+                       return n == cnt ? CMD_RET_SUCCESS : CMD_RET_FAILURE;
                } else {
                        return CMD_RET_USAGE;
                }