]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
i2c: rcar_i2c: Fix i2c read/write errors
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Wed, 30 Sep 2020 12:24:12 +0000 (13:24 +0100)
committerHeiko Schocher <hs@denx.de>
Thu, 1 Oct 2020 03:41:44 +0000 (05:41 +0200)
commit 7c8f821e5dde ("i2c: rcar_i2c: Set the slave address from
rcar_i2c_xfer") blindly called rcar_i2c_set_addr() with read argument
always set to 1 during xfer which introduced read/write errors, whereas
earlier rcar_i2c_read_common() called rcar_i2c_set_addr() with read set to
1 and rcar_i2c_write_common() called rcar_i2c_set_addr() with read set 0.

Fixes: 7c8f821e5dde ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
drivers/i2c/rcar_i2c.c

index 4267bbfa5a961f80ff63f4ecb115ebd841f1b570..663c342cd839a6e9404a117e354cbccad9ad4b21 100644 (file)
@@ -211,7 +211,7 @@ static int rcar_i2c_xfer(struct udevice *dev, struct i2c_msg *msg, int nmsgs)
        int ret;
 
        for (; nmsgs > 0; nmsgs--, msg++) {
-               ret = rcar_i2c_set_addr(dev, msg->addr, 1);
+               ret = rcar_i2c_set_addr(dev, msg->addr, !!(msg->flags & I2C_M_RD));
                if (ret)
                        return ret;