]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: ehci: mxs: fix swapped argument in ehci_writel()
authorDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
Thu, 25 Jan 2018 19:43:58 +0000 (20:43 +0100)
committerMarek Vasut <marex@denx.de>
Thu, 25 Jan 2018 19:59:20 +0000 (20:59 +0100)
ehci_writel() swaps the arguments for address and value. One call
in ehci-mxs ignores that.

This fixes the warning:

drivers/usb/host/ehci-mxs.c: In function ?ehci_hcd_stop?:
drivers/usb/host/ehci-mxs.c:159:19: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
  ehci_writel(tmp, &hcor->or_usbcmd);
                   ^
arch/arm/include/asm/io.h:117:34: note: in definition of macro ?writel?
 #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; })
                                  ^
drivers/usb/host/ehci-mxs.c:159:2: note: in expansion of macro ?ehci_writel?
  ^~~~~~~~~~~

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
drivers/usb/host/ehci-mxs.c

index 6b8d969bb00093c64fc60e983d6c2559083b0eba..9872415562c26203d349f0ca63fa2a0cd9deda80 100644 (file)
@@ -156,7 +156,7 @@ int ehci_hcd_stop(int index)
 
        tmp = ehci_readl(&hcor->or_usbcmd);
        tmp &= ~CMD_RUN;
-       ehci_writel(tmp, &hcor->or_usbcmd);
+       ehci_writel(&hcor->or_usbcmd, tmp);
 
        /* Disable the PHY */
        tmp = USBPHY_PWD_RXPWDRX | USBPHY_PWD_RXPWDDIFF |