]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
lib/rsa: avoid -Wdiscarded-qualifiers
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sun, 9 Jan 2022 14:39:40 +0000 (15:39 +0100)
committerTom Rini <trini@konsulko.com>
Mon, 10 Jan 2022 13:13:24 +0000 (08:13 -0500)
The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *.
Our code drops the const qualifier leading to

In file included from tools/lib/rsa/rsa-sign.c:1:
./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verify_data’:
./tools/../lib/rsa/rsa-sign.c:631:13: warning:
assignment discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
  631 |         rsa = EVP_PKEY_get0_RSA(pkey);
      |             ^

Add a type conversion.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
lib/rsa/rsa-sign.c

index 44f21416ce71e475fdc63a0089a9c8079f6531e3..3b6e5f0f86cf352b1f3073ce6862d51d427acadf 100644 (file)
@@ -628,7 +628,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest)
        if (ret)
                goto err_get_pub_key;
 
-       rsa = EVP_PKEY_get0_RSA(pkey);
+       rsa = (RSA *)EVP_PKEY_get0_RSA(pkey);
        ret = rsa_get_params(rsa, &exponent, &n0_inv, &modulus, &r_squared);
        if (ret)
                goto err_get_params;