]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
cmd: efidebug: check pointer after memory allocation
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Thu, 11 Jan 2024 08:25:35 +0000 (09:25 +0100)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 13 Jan 2024 17:17:47 +0000 (18:17 +0100)
After calling efi_alloc() we must check that the return value is not NULL.

Fixes: f01c961ee34c ("cmd: efidebug: add uri device path")
Addresses-Coverity-ID: 477185 Dereference null return value
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
cmd/efidebug.c

index 836014ab8eabc031c18ef80191a3d1f9596ccc93..aa8523797efbc261aabf547609d0fe3152932a41 100644 (file)
@@ -754,6 +754,10 @@ static int efi_boot_add_uri(int argc, char *const argv[], u16 *var_name16,
 
        uridp_len = sizeof(struct efi_device_path) + strlen(argv[3]) + 1;
        uridp = efi_alloc(uridp_len + sizeof(END));
+       if (!uridp) {
+               log_err("Out of memory\n");
+               return CMD_RET_FAILURE;
+       }
        uridp->dp.type = DEVICE_PATH_TYPE_MESSAGING_DEVICE;
        uridp->dp.sub_type = DEVICE_PATH_SUB_TYPE_MSG_URI;
        uridp->dp.length = uridp_len;