]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools/fitimage: remove redundant format check
authorStefan Eichenberger <eichest@gmail.com>
Mon, 10 Jan 2022 17:48:31 +0000 (18:48 +0100)
committerTom Rini <trini@konsulko.com>
Mon, 24 Jan 2022 15:35:10 +0000 (10:35 -0500)
fit_extract_contents does a fit_check_format even thought it was already
checked during imagetool_verify_print_header.
Therefore, this check is not necessary. This commit removes the
redundancy.

Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
tools/fit_image.c

index f4f372ba62f99586e1db68a56f67a929d1ab5907..62e1796ce5b774f8e9c9ff23347617af965c2fe9 100644 (file)
@@ -884,11 +884,6 @@ static int fit_extract_contents(void *ptr, struct image_tool_params *params)
        /* Indent string is defined in header image.h */
        p = IMAGE_INDENT_STRING;
 
-       if (fit_check_format(fit, IMAGE_SIZE_INVAL)) {
-               printf("Bad FIT image format\n");
-               return -1;
-       }
-
        /* Find images parent node offset */
        images_noffset = fdt_path_offset(fit, FIT_IMAGES_PATH);
        if (images_noffset < 0) {